Conversation
Allow channel name override
joelvarty
reviewed
Apr 12, 2022
Member
joelvarty
left a comment
joelvarty
left a comment
There was a problem hiding this comment.
This looks awesome! Nice work! @joshua-isaac - can you take a look as well, and everything is good, I can bump the version number and publish to NPM?
fix agilityPaths typing
Contributor
|
@joelvarty fixed some typing here to get agilityPaths to work. would you mind checkin it out when you get a chance? |
Contributor
|
we may also want to rename the prop to just |
Author
|
I've changed this to |
fix AgilityPaths & update packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds the ability to pass in an optional channel name to override the one specified in the env. This will mean getAgilityPaths and getAgilityPageProps can access more than one channel in a single site / app