Skip to content

Conversation

@MrSlimCoder
Copy link

Hello :)
I have added eslint configurations for this project it can be usefull in development . what is your thought on that ?

@MrSlimCoder
Copy link
Author

Hey! also added eslint security rules 🏂🤞

@@ -0,0 +1,32 @@
{
"env": {
"browser": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bowser?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is default eslint config :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is default eslint config :

Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd to have this but this is not working with the current prettier config I have. They both should format the code in the same way.

@MrSlimCoder
Copy link
Author

I'd to have this but this is not working with the current prettier config I have. They both should format the code in the same way.

Yup! it can make impact to your prettier config 🤹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants