Add optional stateName parameter to filter states results #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added optional stateName parameter to getStates.js to test: node index.js states --stateName Tennessee node index.js states --stateName "North Carolina"
- update readme with examples for single state - clean up some changes
simplify code for state parameter
filter by state changes
Update master branch
|
thoughts? feedback? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
great project @ahmadawais 👍
I had a need to work with some individual state data and wanted to filter the results to save time. The change as implemented is very simple. I checked and it did not appear that the underlying API supported a state filter so I just did it on the client side.
I also added examples to the readme under the states section.
Hope this is helpful.
Questions or comments welcome.
thanks