ETCD: initial heartbeat thread #1010
Open
+160
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi tstamler! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
|
/ok to test c2065fd |
Contributor
|
/build |
aranadive
reviewed
Nov 13, 2025
aranadive
reviewed
Nov 13, 2025
Contributor
|
/ok to test 4e8f87d |
Contributor
|
/build |
Contributor
|
@tstamler I added the fixes we talked about. |
@tstamler, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Contributor
Author
|
/ok to test 5220637 |
Contributor
Author
|
/build |
tstamler
force-pushed
the
etcd_heartbeat
branch
from
5220637 to
525a807
Compare
Contributor
Author
|
/build |
Contributor
Author
|
/ok to test 525a807 |
aranadive
reviewed
Nov 21, 2025
| NIXL_DEBUG << "Using etcd namespace for agents: " << namespace_prefix; | ||
|
|
||
| etcd::Response response = etcd->leasegrant((heartbeat.count()) * 2); | ||
| lease_id = response.value().lease(); |
Contributor
There was a problem hiding this comment.
is this valid if response is incorrect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a heartbeat mechanism to NIXL ETCD metadata to invalidate stale metadata if an agent dies.