refactor: CMake configuration #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josafatburmeister
temporarily deployed
to
github-pages
GitHub Actions
Inactive
josafatburmeister
changed the title
|
The documentation for this pull request was deployed at https://ai4trees.github.io/pointtree/pr135. |
josafatburmeister
changed the title
josafatburmeister
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
josafatburmeister
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CMake configuration as follows:
set(OpenMP_RUNTIME_MSVC llvm)is removed to link against the Intel OpenMP runtime instead of the LLVM OpenMP runtime when using MSCV, this is necessary to avoid conflicts with the Intel OpenMP runtime used by PyTorchtarget_link_librariesfor the Python bindings is changed fromPUBLICtoPRIVATEto indicate that nothing should link against the Python bindings