This repository was archived by the owner on Jul 10, 2021. It is now read-only.
Fix issue 231, per-sample weights incorrect when using valid_size > 0.0 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2017 13:28
Modifies sknn/backend/lasagne/mlp.py's MultilayerPerceptronBackend's _initialize_impl method to additionally generate a test/train split on the weights vector, if not None, and return it. Modifies sknn/mlp.py's MultiLayerPerceptron's _fit method to expect an additional return value of w from _initialize, which just returns the modified _initialize_impl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies sknn/backend/lasagne/mlp.py's MultilayerPerceptronBackend's
_initialize_impl method to additionally generate a test/train split
on the weights vector, if not None, and return it.
Modifies sknn/mlp.py's MultiLayerPerceptron's _fit method to expect
an additional return value of w from _initialize, which just returns
the modified _initialize_impl