Skip to content

Conversation

@rprata
Copy link

@rprata rprata commented Mar 31, 2025

This commit enables Trickle ICE by allowing candidates to be exchanged incrementally between peers over the signaling channel.

@rprata rprata force-pushed the feat/trickle-ice-support branch 4 times, most recently from 0e61553 to aa5084f Compare April 3, 2025 14:16
@jlaine
Copy link
Collaborator

jlaine commented Apr 6, 2025

Hi! Could you please drop all the changes not related to actual ICE trickle and rebase on top of main?

@jlaine jlaine added the changes requested Some changes are required before the PR can be merged. label Apr 6, 2025
@rprata rprata force-pushed the feat/trickle-ice-support branch from 2a5be00 to 49396bb Compare April 10, 2025 20:41
@rprata rprata force-pushed the feat/trickle-ice-support branch 3 times, most recently from 00141e5 to 80d3ffe Compare April 10, 2025 20:58
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.83%. Comparing base (6ea9d7a) to head (b36da71).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/aioice/ice.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #83      +/-   ##
===========================================
- Coverage   100.00%   99.83%   -0.17%     
===========================================
  Files            7        7              
  Lines         1232     1240       +8     
===========================================
+ Hits          1232     1238       +6     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rprata rprata force-pushed the feat/trickle-ice-support branch from 80d3ffe to 678caab Compare April 10, 2025 21:04
@rprata rprata force-pushed the feat/trickle-ice-support branch from 678caab to b36da71 Compare April 10, 2025 21:08
@jlaine
Copy link
Collaborator

jlaine commented Apr 13, 2025

Hi @rprata ! I'm not sure I understand how this PR helps us: it does indeed "emit" candidates as it discovers them, but we're no closer to connecting while still gathering candidates. Unless I'm mistaken this is a much deeper change, because it means:

  • Changing the internal state machine to allow building new candidate pairs while connecting.
  • Changing the internal state machine to not fail if we reach the end of the check list while still gathering.
  • Reworking the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Some changes are required before the PR can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants