-
Notifications
You must be signed in to change notification settings - Fork 66
feat: adding trickle ice support #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0e61553 to
aa5084f
Compare
|
Hi! Could you please drop all the changes not related to actual ICE trickle and rebase on top of main? |
2a5be00 to
49396bb
Compare
00141e5 to
80d3ffe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
===========================================
- Coverage 100.00% 99.83% -0.17%
===========================================
Files 7 7
Lines 1232 1240 +8
===========================================
+ Hits 1232 1238 +6
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80d3ffe to
678caab
Compare
678caab to
b36da71
Compare
|
Hi @rprata ! I'm not sure I understand how this PR helps us: it does indeed "emit" candidates as it discovers them, but we're no closer to connecting while still gathering candidates. Unless I'm mistaken this is a much deeper change, because it means:
|
This commit enables Trickle ICE by allowing candidates to be exchanged incrementally between peers over the signaling channel.