[WIP] Link to system ls-qpack, fall back to vcpkg #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for
vcpkgfor building wheels for distribution over PyPI, while opportunistically linking to OS-provided packages, all by usingpkgconfvia matze/pkgconfig.The current solution, notably the use of
glob.glob()for prefix detection, is arguably fragile (would break if someone copied over thevcpkg_installedfolder with installed packages from another platform). Probably a clean-up step before the build this would suffice, though.Also: since the maintainer from Fedora renamed the
pkg-configpackage configuration file (Oct 31 2023, https://src.fedoraproject.org/rpms/ls-qpack/c/bc56a0c45fff32c32d157c901e6a57cf1aadc9a6.patch) while waiting their patch (Oct 22 2023, litespeedtech/ls-qpack#55) to be merged upstream, this currently won't work on Fedora. Compare the file names:liblsqpack.sols-qpack.pclibls-qpack.alsqpack.pcI have no experience in such communication regarding breaking name changes, so I cannot make a decision yet.
Closes: #42
PS: This is still a work in progress and should wait until the ad-hoc patches have been upstreamed, or when better solutions are found and implemented here.