[Online]Enable ds derivation in online for rename-only derivations #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyu-hou
approved these changes
Nov 14, 2025
Shiyinghaha
approved these changes
Nov 14, 2025
hzding621
reviewed
Nov 14, 2025
Collaborator
hzding621
left a comment
hzding621
left a comment
There was a problem hiding this comment.
Can we add a test case for this?
Collaborator
Plus 1. We should add a new testing case. |
3 tasks
Collaborator
Collaborator
|
close with #1071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we are enabling derivation on ds for offline(It is used for the case where the wildcard derivation is not used and ds is not included in final schema), but online derivation on ds is disabled for rename-only derivations, which caused online-offline consistency.
The change is to enable the ds derivation in online for rename-only derivations
Why / Goal
Test Plan
Checklist
Reviewers
@pengyu-hou @hzding621 @Shiyinghaha