-
Notifications
You must be signed in to change notification settings - Fork 266
MCP Recon code reusability added for tool, resource discovery, issue … #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/mini-runtime-release
Are you sure you want to change the base?
Conversation
…fixed and capability added
| } | ||
|
|
||
| public static boolean useHostCondition(String hostName, HttpResponseParams.Source source) { | ||
| public static boolean useHostCondition(String hostName, HttpResponseParams.Source source, boolean isRecon) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HttpResponseParams is already available everywhere. Instead of passing a new variable in all the places.
We can simply create a new source HttpResponseParams.Source.MCP_RECON
Your detection mechanism can set the source and here you can check for it.
This can in future be used by others or for fitlering( I think we do store the source somewhere )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HttpResopnse param is a very widely used class, please do regression testing explicitly before deploying
Pipeline
Traffic Collector(daemonset) -> kafka -> Mini runtime -> Dashboard UI
- Make sure traffic ingestion is happening
- Make sure changes are backwards compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nayanakto @aanchalakto I have not checked the rest of the code. Please review.
I just checked the hostCondition thing.
apps/mini-runtime/src/main/java/com/akto/hybrid_runtime/McpToolsSyncJobExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI Security analysis: "Automated analysis found no security findings in the modified files. This does not guarantee absence of defects; follow-up checks are recommended."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 10.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
…fixed and capability added