Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Conversation

@tchiotludo
Copy link

First plugin, tell what do you think

@ManuelSchneid3r
Copy link
Member

Theres #210. Please colaborate to get best of both worlds.

@tchiotludo
Copy link
Author

tchiotludo commented Mar 31, 2025

oops I didn't see this one, even it's seems closed since related to github, my plugin seems to target wider area of the github api (issues, pull request and repositories) and that can be extended (based on the search prefix). I will ask to @AirOnSkin if he want me to wider its plugins

@ManuelSchneid3r
Copy link
Member

I wrote a cpp version because i needed a playground for the internal tooling (oauth, rest).
https://github.com/albertlauncher/albert-plugin-github/blob/main/src/plugin.cpp
Id like to discuss the interface. u, r, i are there. However they are mostly useless. currently there are two global items that map to the user specify search of repos and issuses. however this is not that convenient and rigid. I thought about adding R and I which use default search parameters. this however is less transparent and may confuse users.
Another approach is to let users define their own shotcuts.

@tchiotludo
Copy link
Author

Nice work 👏

I would agree that the r u i prefix are not optimal but I didn't know how to manage this in the Albert landscape (especially in python)

The best UX IMO could be to allow people configure multiple triggers (ghi, ghr) with a configuration for each one.
This will allow crazy things like:

  • ghme: state:open assignee:@me sort:updated-desc
  • ghr: list of repositories
  • ghorg: state:open org:albertlauncher sort:updated-desc`
  • ghpr: is:pr state:open org:albertlauncher sort:updated-desc

We could clone the WebSearch plugin configuration to achieve this configuration
image

with :

  • type: ISSUES PRS REPOSITORIES USERS
  • filters:: the search query
  • shortcut: the shortcut used

The last remaining thing how to get the personal access token

WDYT?

@AirOnSkin
Copy link

I like the idea of user defined shortcuts a lot. If the CPP version of the plugin will be included in Albert in the future my PR #210 can be closed.

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented May 5, 2025

Current state

Config
Bildschirmfoto 2025-05-05 um 12 09 45

Default triggered gives filterable saved searches
Bildschirmfoto 2025-05-05 um 12 11 44

Saved searches are globally available
Bildschirmfoto 2025-05-05 um 12 18 53

Activation starts the search
Bildschirmfoto 2025-05-05 um 12 11 48

r, u and i as expected. n lists notifications. Any ideas for improvement?

@AirOnSkin
Copy link

Any ideas for improvement?

I'd say go ahead and release it. Improvement requests will come when people start using it.

@ManuelSchneid3r
Copy link
Member

hey guys please do not put more effort in this. i am currently implementing this in a native plugin.
If you have any ideas let me know: albertlauncher/albert-plugin-github#1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants