Closed
Conversation
alchemist51
force-pushed
the
feature/datafusion
branch
from
8ec45c4 to
81d0c1d
Compare
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
alchemist51
force-pushed
the
indexing-changes
branch
from
a277a23 to
6173757
Compare
alchemist51
force-pushed
the
indexing-changes
branch
from
20a7b27 to
002ab31
Compare
Bukhtawar
reviewed
Mar 9, 2026
Comment on lines
+44
to
+49
| public FileInfos flush(FlushIn flushIn) throws IOException { | ||
| writer.forceMerge(1); | ||
| WriterFileSet.Builder writerFileSetBuilder = | ||
| WriterFileSet.builder().directory(directoryPath).writerGeneration(writerGeneration).addNumRows(writer.getDocStats().numDocs); | ||
| return FileInfos.builder().putWriterFileSet(DataFormat.LUCENE, writerFileSetBuilder.build()).build(); | ||
| } |
There was a problem hiding this comment.
Why are we performing a force merge in flush?
Owner
Author
There was a problem hiding this comment.
Each CompositeWriter creates a child parquet writer and lucene writer. The lucene writer can have more than 1 segments hence to keep the mapping consistent between a lucene and parquet segment we have to do a force merge.
Owner
Author
There was a problem hiding this comment.
Please use this as the primary PR on the feature branch: https://github.com/opensearch-project/OpenSearch/pull/20790/changes
I will mark this close to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.