Run CI on supported versions of Go#356
Conversation
|
I didn't remove the |
| run: ./bin/hermit env -r >> $GITHUB_ENV | ||
|
|
||
| - name: Setup Golang Environment | ||
| uses: actions/setup-go@v5 |
There was a problem hiding this comment.
Minor nit, It's recommended to pin this to a git hash for supply chain security.
Renovate can also keep this up to date.
| uses: actions/setup-go@v5 | |
| uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 |
There was a problem hiding this comment.
yeah but this repo is not really maintained...I'm not sure who would merge all the PRs...
There was a problem hiding this comment.
I mean I’d be down to help maintain it
There was a problem hiding this comment.
I appreciate the effort but I personally don't think it's useful to test on historical versions of Go at all, for multiple reasons:
- Only the most recent 2 versions are supported by the Go team, and I generally adhere to this policy too.
- The Go backwards compatibility promise is incredibly reliable.
The other changes seem reasonable.
There was a problem hiding this comment.
My usual recommendation here is to update the go directive in the go.mod file to support the latest 2 releases. This way the matrix test matches. This is the policy we use for most of the Prometheus ecosystem.
There was a problem hiding this comment.
I changed it to only test oldstable and stable.
lucacome
changed the title
|
I've updated the PR with the suggestions. Do we still need |
|
Thanks for putting in the effort on this PR, but I'm not interested in running tests on multiple versions of Go. I'd prefer to keep Hermit as the test path. |
3 participants
This was initially part of #354 but I decided to create a separate PR, so it can be maybe merged sooner.