Performance improvements #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit c74e614432a1fb0ade7dfc9d9dac6cab0582f26e
Author: Andrew Porritt <aporritt@gogo-robot.com>
Date: Wed Jun 9 12:59:06 2021 +0100
Fix quotes
commit 3d74cc65dfaf2178c5c233b0dc8c766d559527a3
Author: Andrew Porritt <aporritt@gogo-robot.com>
Date: Wed Jun 9 12:55:49 2021 +0100
Rewrite to improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite to address the performance issues with the library. Originally, the library would read single characters from the file and create a lot of temporary strings. This rewrite reads the file in chunks of up to 16KiB depending on the file size, pushes the data into an array while counting new lines, then finally reverses the array. It's possible that further performance improvements could be gained for large line counts depending on how arrays are handled internally in Node when pushing / reversing, but I haven't looked into that so far.
This should help with #26