fix: optional timestamp genesis#327
Closed
joe-p wants to merge 59 commits intoalgorandecosystem:mainfrom
Closed
Conversation
fix: build errors from latest main changes
fix: change sample app function reference
wip: android test with README
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: kotlin support
feat: serde path to error
fix: Vec<u8> for potentially non-ascii data
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the timestamp field optional in the genesis response model and adds comprehensive Android support to the repository, including build infrastructure, testing, and CI integration.
Changes:
- Made the
timestampfield optional in theGenesismodel to match actual API behavior - Added Android/Kotlin package support with build scripts, tests, and CI workflow
- Improved error handling across all API clients by integrating
serde_path_to_errorfor better deserialization error messages - Fixed handling of msgpack string/binary data that may contain non-UTF-8 bytes
Reviewed changes
Copilot reviewed 158 out of 167 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/algod_client/src/models/genesis.rs | Made timestamp field optional in Genesis model |
| api/specs/algod.oas3.json | Removed timestamp from required fields in Genesis schema |
| tools/build_pkgs/src/android.rs | Added Android build script for generating AAR packages |
| .github/workflows/android_ci.yml | Added CI workflow for Android builds and tests |
| crates//src/apis/.rs | Updated all API clients to use serde_path_to_error for better error messages |
| crates/algokit_transact/src/error.rs | Updated error types to include deserialization path information |
| packages/android/algokit_transact/* | Added complete Android package with tests and configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| assert!( | ||
| msg == "Transaction fee 2470 µALGO is greater than max fee 1000 µALGO", | ||
| "Unexpected error message: {}", | ||
| "Unexpected error err_msg:{}", |
There was a problem hiding this comment.
Corrected 'err_msg:' to 'message:' to maintain consistency with the original error message format.
Suggested change
| "Unexpected error err_msg:{}", | |
| "Unexpected error message:{}", |
| } | ||
| if threshold == 0 || threshold as usize > subsignatures.len() { | ||
| return Err(AlgoKitTransactError::InvalidMultisigSignature { message: "Threshold must be greater than zero and less than or equal to the number of sub-signers".to_string() }); | ||
| return Err(AlgoKitTransactError::InvalidMultisigSignature { err_msg:"Threshold must be greater than zero and less than or equal to the number of sub-signers".to_string() }); |
There was a problem hiding this comment.
Missing space after colon in field initialization. Should be err_msg: instead of err_msg:.
Suggested change
| return Err(AlgoKitTransactError::InvalidMultisigSignature { err_msg:"Threshold must be greater than zero and less than or equal to the number of sub-signers".to_string() }); | |
| return Err(AlgoKitTransactError::InvalidMultisigSignature { err_msg: "Threshold must be greater than zero and less than or equal to the number of sub-signers".to_string() }); |
Collaborator
Author
|
Closing in favor of #332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the timestamp in the genesis response not being optional
Needs #323 to merge first