fix: Fix incorrect edge table state when transforming between bundled and unbundled#28
fix: Fix incorrect edge table state when transforming between bundled and unbundled#28zhanglei1949 merged 6 commits intomainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Use cibuildwheel to build wheels for all platforms and archs.
zhanglei1949
force-pushed
the
fix-etable-trans
branch
from
eed8593 to
dc97a9e
Compare
|
@greptile |
|
@greptile |
|
Waiting string propblem to be resolved. |
|
@greptile |
zhanglei1949
force-pushed
the
fix-etable-trans
branch
from
a4d7dcd to
5c32837
Compare
|
@greptile |
There was a problem hiding this comment.
zhanglei1949 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
@greptile |
There was a problem hiding this comment.
zhanglei1949 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
Pull request overview
Fixes inconsistent internal EdgeTable state transitions when edge properties are added/dropped, preventing unintended flips between bundled and unbundled storage (Fix #58).
Changes:
- Update
EdgeTableschema-alter paths to correctly rebuild CSR/Table when adding/dropping properties (including empty ↔ bundled ↔ unbundled transitions). - Improve handling for bundled empty edge data and unsupported type reporting/behavior in CSR creation/insertion helpers.
- Add/extend regression tests in both Python DDL tests and C++ storage tests to validate transitions and capacity/size invariants.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/python_bind/tests/test_ddl.py | Adds a DDL regression test for dropping/adding edge table columns across reopen. |
| tests/storage/test_vertex_table.cc | Minor formatting fix (brace alignment) to keep tests consistent. |
| tests/storage/test_edge_table.cc | Adds extensive transition tests and strengthens assertions around bundled/unbundled size/capacity behavior. |
| src/storages/graph/edge_table.cc | Implements the core fix: rebuild logic for bundled/unbundled conversions during Add/DeleteProperties; adjusts CSR creation/edge insertion behavior. |
| include/neug/storages/graph/edge_table.h | Updates the bundled-CSR rebuild helper signature to support conversion using a remaining column. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
zhanglei1949 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Fix #58