Reuse RCTBridge for the share view. Fixes #64#144
Open
rbscott wants to merge 1 commit intoalinz:masterfrom
Open
Reuse RCTBridge for the share view. Fixes #64#144rbscott wants to merge 1 commit intoalinz:masterfrom
rbscott wants to merge 1 commit intoalinz:masterfrom
Conversation
marctorrelles
added a commit
to marctorrelles/react-native-share-extension
that referenced
this pull request
Mar 15, 2019
|
Hi, Do you have an example for newer React Native versions (0.59.x)? I'm using react-native v0.59.5 and I see that the RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
moduleName:@"appName"
initialProperties:nil];In previous versions was: jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"appName"
initialProperties:nil
launchOptions:launchOptions];Should the share extension use the same coding to create the view? |
|
hey @mtzfactory by any chance could u test this or recall an alternative to it? I know its been a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the general idea for fixing memory issues inside of the share view. This still needs to be tested. I didn't see instructions for running react-native-share-extension independently for testing, so I am putting together a mini project to verify this works.
As implemented, this should be backwards compatible.