Remove stopping provider finder if find one#62
Open
seclace wants to merge 1 commit intoalinz:masterfrom
Open
Conversation
|
Agree! Without this fix many apps share incorrect data. |
Contributor
|
You could just put IMAGE_IDENTIFIER check in the first if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This package is very useful and thanks for your work!
I've tried it with sharing from app apple.news and was confused when began sharing.
Apple.news app shares two providers - string
titleand urlurl, but in extension takes only first matching - if string encounters first then thedataprop will be the string, if it image so thedatawill be the image and so on. I'm very foolish in objective-c and don't know, how it could be reached to take the all providers from the app sharing you from and pass them to the javascript side.Because of it I remove stopping the attachments iterator when provider found. It will be better if someone who knows objective-c could update this code to reach the goal.
How do you think, @alinz ?