Share image from other application ( Whatsapp, facebook, strava, google photos, etc ) only on android#82
Open
firman123 wants to merge 2 commits intoalinz:masterfrom
Open
Share image from other application ( Whatsapp, facebook, strava, google photos, etc ) only on android#82firman123 wants to merge 2 commits intoalinz:masterfrom
firman123 wants to merge 2 commits intoalinz:masterfrom
Conversation
fix bug when share image from other application
add import class
Collaborator
|
@firman123 Do you have some more information about this PR's functionality? It would be nice to see the PR include updates to the README with new install instructions, information about how the data is passed back via Specifically, there's another PR on this repository allowing multiple data on both iOS and Android. |
AndrewHenderson
requested changes
Nov 10, 2018
Collaborator
There was a problem hiding this comment.
@firman123 I tested these changes, but the app now crashes when attempting to share from Gallery, Photos, Messages, Gmail, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Don't forget to add write WRITE_EXTERNAL_STORAGE permission in your app