Bump FairLogger to v2.1.0 and InfoLogger to v2.8.2#5763
Conversation
|
It looks like there is a genuine incompatibility between InfoLogger and the new FairLogger. |
|
ok, I will check if it is only these two |
|
Keep also in mind that c_str() is guaranteed to be 0 terminated, string_view is not. |
|
waiting for AliceO2Group/InfoLogger#95 to also bump InfoLogger here |
|
My bad, I messed up with the include file during the test... Will fix shortly |
sy-c
left a comment
There was a problem hiding this comment.
I fixed infologger and pushed v2.8.2
The include issue escaped my attention as I did the release integration tests using InfoLogger instead of libInfoLogger (which is the one included by the O2 components).
|
the compiler on macOS throws a warning when using enums in switch statements (in this case The O2 PR to fix this is already open but needs the bump of FairLogger first: AliceO2Group/AliceO2#13957 |
|
ping @ktf |
Introducing a "critical" log message severity, required to distinguish critical errors for shifter operation.