Skip to content

Add environment variable exports for dependencies #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackal1-66 wants to merge 1 commit into from
Closed

Add environment variable exports for dependencies #6025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions o2dpg-sim-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ rm -Rf ${TEST_DIR}
mkdir ${TEST_DIR}
pushd ${TEST_DIR}

# Add Herwig, GSL, ThePEG and nlohmann_json packages to root include path and library path at building time
export ROOT_INCLUDE_PATH="$THEPEG_ROOT/include:$HERWIG_ROOT/include:$GSL_ROOT/include:$NLOHMANN_JSON_ROOT/include:$ROOT_INCLUDE_PATH"
export LD_LIBRARY_PATH="$THEPEG_ROOT/lib/ThePEG:$HERWIG_ROOT/lib/Herwig:$GSL_ROOT/lib:$LD_LIBRARY_PATH"
Copy link
Collaborator

@sawenzel sawenzel Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a better place for this is direclty in the "env" section of each recipe (which constructs the build environment for alibuild recipes). Then you don't have to do it in each recipe using Herwig...

Copy link
Contributor Author

@jackal1-66 jackal1-66 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had multiple issues while reproducing this on a local docker due to some path issues. We tested prepend-path with Giulio but it didn't work (aliBuild fails while building ThePEG or Herwig). I will check if env works, I would prefere it over exporting the path directly.

Copy link
Collaborator

@sawenzel sawenzel Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I actually meant prepend_path. Not sure what the difference with env is... but anyways I think that such yaml setting would be more appropriate than manually doing exports.

Copy link
Member

@ktf ktf Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env sets the variable, prepend_path adds to it.

Historically, prepend_path and env are available only in dependencies, not in the actual build script, to make sure that the script was "standalone" and could be easily cut & pasted to reproduce issues. That said, the correct solution here would be to have the changes in HERWIG and ThePeg, however that cannot be done due to a relocation issue in pythia8, IIUC. Once we fix it, we can clean this up.


# check if LHAPDF data path is set
if [ -z "$LHAPDF_DATA_PATH" ]; then
echo "Setting LHAPDF_DATA_PATH to $LHAPDF_ROOT/share/LHAPDF:$LHAPDF_PDFSETS_ROOT/share/LHAPDF"
Expand Down
Loading