Open
Conversation
|
|
hoenic07
force-pushed
the
jruby-compatibility
branch
from
1f5f096 to
934457e
Compare
hoenic07
force-pushed
the
jruby-compatibility
branch
from
23c8ebb to
b99fa55
Compare
Author
|
The test coverage seemed to decrease, because some lines are now only hit by JRuby and others only by other Ruby versions. So this shouldn't be an issue. |
Author
|
Hi! |
hmtanbir
approved these changes
May 19, 2021
hmtanbir
reviewed
May 19, 2021
| require_relative 'oss/bucket' | ||
| require_relative 'oss/client' | ||
| require_relative 'crcx' | ||
| require_relative 'crcx' unless RUBY_PLATFORM =~ /java/ No newline at end of file |
Author
There was a problem hiding this comment.
I hope I've added the new line as you imagined it
hoenic07
force-pushed
the
jruby-compatibility
branch
from
1dce4ad to
4ce07e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Native Extension for the CRC was added, the SDK couldn't be used with JRuby anymore. In this PR the Native Extension was replaced with the CRC gem (https://github.com/dearblue/ruby-crc) if JRuby is used as Ruby platform. Nothing has changed for other platforms.