Refactor monkeypatches for RestClient and String.to_bool#93
Open
marcogregorius wants to merge 1 commit intoaliyun:masterfrom
Open
Refactor monkeypatches for RestClient and String.to_bool#93marcogregorius wants to merge 1 commit intoaliyun:masterfrom
marcogregorius wants to merge 1 commit intoaliyun:masterfrom
Conversation
|
|
marcogregorius
force-pushed
the
remove-monkey-patches
branch
from
8debaa4 to
02ee664
Compare
|
@huiguangjun I wonder what you think of this changes, is this acceptable ? We are proposing these changes in relation to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the monkey patches in:
RestClient::Payload::Baserefactored to use refinements so that the effect of the patch is scoped just toAliyun::OSS::HTTPString.to_boolmonkeypatch to a classmethod inAliyun::OSS::Util.to_bool