Skip to content

Now, reward_fn lives in LLMRayActor. #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Now, reward_fn lives in LLMRayActor. #1225

wants to merge 1 commit into from
+248 −136

Conversation

@finbarrtimbers
Copy link
Collaborator

@finbarrtimbers finbarrtimbers commented Nov 24, 2025 •
edited
Loading

Runs:

@finbarrtimbers finbarrtimbers mentioned this pull request Nov 24, 2025
Open
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-25 22:49:39.612567452 +0000
+++ site-pr/sitemap.xml	2025-11-25 22:49:36.235470329 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-25</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-25</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 00:44:18.134309052 +0000
+++ site-pr/sitemap.xml	2025-11-26 00:44:15.524327761 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 15:35:50.138416591 +0000
+++ site-pr/sitemap.xml	2025-11-26 15:35:47.157435630 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 15:56:58.752319600 +0000
+++ site-pr/sitemap.xml	2025-11-26 15:56:56.715339651 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 16:10:08.509203117 +0000
+++ site-pr/sitemap.xml	2025-11-26 16:10:06.233215713 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 17:09:57.006217805 +0000
+++ site-pr/sitemap.xml	2025-11-26 17:09:54.491226702 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 18:59:44.789581101 +0000
+++ site-pr/sitemap.xml	2025-11-26 18:59:41.664612135 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 20:10:32.684389026 +0000
+++ site-pr/sitemap.xml	2025-11-26 20:10:29.655391830 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Documentation Changes Detected

📄 sitemap.xml 
--- site-base/sitemap.xml	2025-11-26 20:40:29.066222102 +0000
+++ site-pr/sitemap.xml	2025-11-26 20:40:26.518212992 +0000
@@ -9,6 +9,10 @@
          <lastmod>2025-11-26</lastmod>
     </url>
     <url>
+         <loc>https://github.com/allenai/open-instruct/nccl_hang_investigation/</loc>
+         <lastmod>2025-11-26</lastmod>
+    </url>
+    <url>
📄 sitemap.xml.gz 
Binary files site-base/sitemap.xml.gz and site-pr/sitemap.xml.gz differ

Showing first 10 lines of diff for each changed file (up to 5 files, excluding search indices).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@finbarrtimbers