fix: set species fullName on variant search result documents (SCRUM-5966)#1562
Closed
fix: set species fullName on variant search result documents (SCRUM-5966)#1562
Conversation
The Species object created in VariantSummaryConverter only had abbreviation set. VariantSearchResultConverter calls getSpecies().getFullName() to populate the species field on variant_search_result documents, which returned null because fullName was never set. This caused the species facet to show no values in the variant search category.
|
Claude Code Review Skipped — only 1 lines changed (<= 3). Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VariantSummaryConvertercreates aSpeciesobject when building variant documents from VCF data, but only setsabbreviation-- notfullNameVariantSearchResultConvertercallsgetSpecies().getFullName()to populate thespeciesfield onvariant_search_resultdocuments, which returnsnullbecausefullNamewas never setspecies.setFullName(speciesType.getName())so variant search result documents get the species name (e.g. "Homo sapiens"), enabling the species facet to workTest plan
variant_search_resultdocuments now have a populatedspeciesfieldhttps://stage.alliancegenome.org/search?category=variant_search_result