SCRUM-3302 add experimental conditions for the phenotype download fil…

[cmpich]

…e on gene and allele page

[claude]

Code Review — PR #1565

Summary: Adds two new columns ("Experimental Condition" and "Condition Modifier") to the phenotype download TSV, populated from primary annotation condition relations with a fallback to document-level aggregated values. The PhenotypeDownloadRow model gets two new fields to match.

Bug: Potential NullPointerException on cr.getConditions()

File: PhenotypeAnnotationToTdfTranslator.java, line 78

cr.getConditions().forEach(ec -> parts.add(ec.getConditionSummary()));

getConditions() can return null — the existing codebase guards against this (see DiseaseAnnotation.java:176: if (getConditions() != null)). If a ConditionRelation has a type but no conditions populated, this will throw an NPE and break the entire download for the user.

Suggested fix: Add a null/empty guard before iterating:

if (cr.getConditions() != null) {
    cr.getConditions().forEach(ec -> parts.add(ec.getConditionSummary()));
}

Or use CollectionUtils.isNotEmpty(cr.getConditions()) to stay consistent with the style used elsewhere in this file.

Everything else looks correct

• The new download headers are inserted in a sensible column order.
• The method signature change from this::getPhenotypeDownloadRow to (pa, annotation) -> getPhenotypeDownloadRow(pa, annotation) correctly threads the document through for the fallback logic.
• The fallback from primary annotation conditions → document-level aggregated conditions is a reasonable approach.
• The PhenotypeDownloadRow model changes are straightforward Lombok fields.