Skip to content

Implement log returns prediction and fix timestamp issues #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
architavasuki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement log returns prediction and fix timestamp issues #31

architavasuki wants to merge 2 commits into from

Conversation

@architavasuki
Copy link

@architavasuki architavasuki commented Jul 31, 2025

  • Model now trains successfully with log returns as target
  • No more timestamp conversion crashes
  • Improved error handling and debugging capabilities

@architavasuki
Added log returns target and fixed timestamp corruption from data pro…
1ed10e4 
…viders. Improved data alignment and added debugging.
clementupshot
clementupshot previously approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@clementupshot clementupshot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! Some suggestions:

  • Fix the potential KeyError in load_frame()
  • Consider pinning specific versions instead of latest
  • Update README.md to mention the log returns prediction approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clementupshot clementupshot clementupshot approved these changes

@spooktheducks spooktheducks Awaiting requested review from spooktheducks

+2 more reviewers

@Syaidhelmi Syaidhelmi Syaidhelmi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@architavasuki @Syaidhelmi @clementupshot