Skip to content

[WHIT-2990] Expand news articles schema to allow details.images#3890

Merged
lauraghiorghisor-tw merged 1 commit intomainfrom
expand-news-article-schema-to-allow-images
Mar 10, 2026
Merged

[WHIT-2990] Expand news articles schema to allow details.images#3890
lauraghiorghisor-tw merged 1 commit intomainfrom
expand-news-article-schema-to-allow-images

Conversation

@lauraghiorghisor-tw
Copy link
Contributor

@lauraghiorghisor-tw lauraghiorghisor-tw commented Feb 17, 2026

This is to make the payload consistent with the latest payload for non-embeddable images, such as config-driven topical events' header and logo images. The single image property will be removed once we republish all the news articles.

Related: alphagov/whitehall#11189 and alphagov/frontend#5335
Will be followed by #3933 once the news articles are republished.
Also unblocks: alphagov/govuk_publishing_components#5327

Jira

Left to do in subsequent PR: update the example JSONS as well.

@lauraghiorghisor-tw lauraghiorghisor-tw changed the title Expand news articles schema to allow images [WHIT-2990] Expand news articles schema to allow images Feb 17, 2026
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the expand-news-article-schema-to-allow-images branch from 71529bd to c236517 Compare February 24, 2026 09:31
@lauraghiorghisor-tw lauraghiorghisor-tw marked this pull request as draft February 24, 2026 15:02
@lauraghiorghisor-tw
Copy link
Contributor Author

Paused waiting for confirmation on sources structure.

@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the expand-news-article-schema-to-allow-images branch from c236517 to d87b982 Compare February 24, 2026 15:06
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the expand-news-article-schema-to-allow-images branch from d87b982 to a1f0ad4 Compare March 6, 2026 11:11
@lauraghiorghisor-tw lauraghiorghisor-tw changed the title [WHIT-2990] Expand news articles schema to allow images [WHIT-2990] Expand news articles schema to allow details.images Mar 6, 2026
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the expand-news-article-schema-to-allow-images branch from a1f0ad4 to e640526 Compare March 6, 2026 16:00
This is to make the payload consistent with the latest payload for non-embeddable images, such as config-driven topical events' header and logo images. The single `image` property will be removed once we republish all the news articles.
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the expand-news-article-schema-to-allow-images branch from e640526 to 1ad71d5 Compare March 10, 2026 09:26
@lauraghiorghisor-tw lauraghiorghisor-tw marked this pull request as ready for review March 10, 2026 09:26
Copy link
Contributor

@ryanb-gds ryanb-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it might be nice for the frontend team if we added an instance of this to one of the examples

@lauraghiorghisor-tw
Copy link
Contributor Author

Approving, but it might be nice for the frontend team if we added an instance of this to one of the examples

I have noted that as a todo ;)

I am rather surprised that no tests have broken due to me not updating the examples (and I have touched FE and govuk-publishing-components). So I am sort of trying to see how far I can get until I HAVE to update them 😅

@lauraghiorghisor-tw lauraghiorghisor-tw merged commit 13766be into main Mar 10, 2026
56 of 57 checks passed
@lauraghiorghisor-tw lauraghiorghisor-tw deleted the expand-news-article-schema-to-allow-images branch March 10, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants