[WHIT-2990] Expand news articles schema to allow details.images#3890
Merged
lauraghiorghisor-tw merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
71529bd to
c236517
Compare
Contributor
Author
|
Paused waiting for confirmation on |
c236517 to
d87b982
Compare
d87b982 to
a1f0ad4
Compare
details.images
a1f0ad4 to
e640526
Compare
This is to make the payload consistent with the latest payload for non-embeddable images, such as config-driven topical events' header and logo images. The single `image` property will be removed once we republish all the news articles.
e640526 to
1ad71d5
Compare
ryanb-gds
approved these changes
Mar 10, 2026
Contributor
ryanb-gds
left a comment
There was a problem hiding this comment.
Approving, but it might be nice for the frontend team if we added an instance of this to one of the examples
Contributor
Author
I have noted that as a todo ;) I am rather surprised that no tests have broken due to me not updating the examples (and I have touched FE and govuk-publishing-components). So I am sort of trying to see how far I can get until I HAVE to update them 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make the payload consistent with the latest payload for non-embeddable images, such as config-driven topical events' header and logo images. The single
imageproperty will be removed once we republish all the news articles.Related: alphagov/whitehall#11189 and alphagov/frontend#5335
Will be followed by #3933 once the news articles are republished.
Also unblocks: alphagov/govuk_publishing_components#5327
Jira
Left to do in subsequent PR: update the example JSONS as well.