Clang tidy add extra arg option and return 1 when any error is catched.

[wuisky]

Hi there. Thank you for developing such nice tool.
However, i noticed that rclcpp use some c++17 features,
and without passing --extra-arg=-std=c++17 to clang-tidy it will report errors in these headers.
After this patch, we can pass extra-arg just like:

$ ament_clang_tidy path_to_compile_commands.json  --extra-arg=-std=c++17  --extra-arg=what-ever-you-want-to-pass

Also, i fix issues mentioned in #350 #411.
Hope this helps.

[pucciland95]

A gentle ping since this is a particularly important update to let ament_clang_tidy be usable. Could this change also be ported to Humble branch?

Cheers,

Niccolo

[wuisky]

@clalancette could you take a look of this PR?

[acarrillo-civ]

This would be a great improvement, making ament_clang_tidy significantly easier to use if you want your build to fail on lint errors.

[adivardi]

Is there any update on that? Without that, running ament_clang_tidy in CI is not useful, since it will always pass