Update RSA.java for remove line break on Android#169
Open
erickcrus wants to merge 1 commit intoamitaymolko:masterfrom
Open
Update RSA.java for remove line break on Android#169erickcrus wants to merge 1 commit intoamitaymolko:masterfrom
erickcrus wants to merge 1 commit intoamitaymolko:masterfrom
Conversation
Fix line breaking for Android implementation. If you want to use signature in header of a HTTP Request, you'll get errors. This solution grant that line brakes wont be added to base64 string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix line breaking for Android Base64 encoding
This fix ensures that line breaks are not added to Base64 strings when used in HTTP request headers. Without this fix, using signatures in HTTP request headers on Android could result in errors due to unwanted line breaks in the Base64 encoded string.