Skip to content

Conversation

@hhoww
Copy link

@hhoww hhoww commented May 9, 2024

No description provided.

@vercel
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rnas ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:13am

@ice-cap0
Copy link

can we get this please

Copy link

@ice-cap0 ice-cap0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! tested

@CoryWritesCode
Copy link

Would be nice to have docs updated with this PR too

@code-504
Copy link

Any news?

@flatsteve
Copy link

Leaving a comment here in case it helps anyone using a normal React Native SectionList within a sheet.

I had the issue that scrolling within the SectionList was inconsistent and sometimes wouldn't work at all (especially on Android).

My solution was to add the renderScrollComponent prop to the SectionList and use the ScrollView implementation from react-native-actions-sheet e.g:

import { ScrollView } from "react-native-actions-sheet";

<SectionList
  ...allYourNormalProps
  renderScrollComponent={props => <ScrollView {...props} />}
/>

Don't worry if you don't see this prop in the React Native SectionList docs - renderScrollComponent is available as it extends VirtualizedList https://reactnative.dev/docs/virtualizedlist

P.S. @ammarahm-ed thank you so much for updating this project recently, your work is massively appreciated!
P.P.S ^ I hope I'm doing this correctly - fixed my bug so 🤞

@ammarahm-ed
Copy link
Owner

Leaving a comment here in case it helps anyone using a normal React Native SectionList within a sheet.

I had the issue that scrolling within the SectionList was inconsistent and sometimes wouldn't work at all (especially on Android).

My solution was to add the renderScrollComponent prop to the SectionList and use the ScrollView implementation from react-native-actions-sheet e.g:

import { ScrollView } from "react-native-actions-sheet";

<SectionList
  ...allYourNormalProps
  renderScrollComponent={props => <ScrollView {...props} />}
/>

Don't worry if you don't see this prop in the React Native SectionList docs - renderScrollComponent is available as it extends VirtualizedList https://reactnative.dev/docs/virtualizedlist

P.S. @ammarahm-ed thank you so much for updating this project recently, your work is massively appreciated!
P.P.S ^ I hope I'm doing this correctly - fixed my bug so 🤞

That is the correct way to do it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants