Skip to content

upgraded dependencies to support AndroidX#112

Open
Bahaaib wants to merge 3 commits intoammaratef45:masterfrom
Bahaaib:master
Open

upgraded dependencies to support AndroidX#112
Bahaaib wants to merge 3 commits intoammaratef45:masterfrom
Bahaaib:master

Conversation

@Bahaaib
Copy link
Collaborator

@Bahaaib Bahaaib commented May 30, 2019

Track migration issue here: #111
The changes cause a build failure to the android version due to a conflict with barcode scan library & AndroidX.
To reproduce the failure log: flutter run -v

@0crat 0crat added the scope label May 30, 2019
@0crat
Copy link
Collaborator

0crat commented May 30, 2019

Job #112 is now in scope, role is REV

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   36.45%   36.45%           
=======================================
  Files           7        7           
  Lines         299      299           
=======================================
  Hits          109      109           
  Misses        190      190

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aef02a...e395683. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented May 30, 2019

This pull request #112 is assigned to @aqeel-hashim/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @ammaratef45/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2019

@aqeel-hashim/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   36.45%   36.45%           
=======================================
  Files           7        7           
  Lines         299      299           
=======================================
  Hits          109      109           
  Misses        190      190

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aef02a...159d435. Read the comment docs.

@Bahaaib Bahaaib requested a review from ammaratef45 September 15, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants