Add notification history panel with tabbed bottom panel#78
Add notification history panel with tabbed bottom panel#78
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b142938888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| ); | ||
| } | ||
| return; |
There was a problem hiding this comment.
Avoid dropping bottom-panel widget updates prematurely
This early return diverts plugin-widgets-updated events away from the legacy [data-plugin-handle] container path, but frontend/index.html still creates those sidebar containers for every plugin-panel-registered event and does an initial request_plugin_render there. For bottom panels, that leaves a duplicated sidebar copy that never refreshes after the first render while the tab view keeps updating, which produces inconsistent UI state. Either stop creating sidebar containers for location === 'bottom' or keep updating them until that registration path is migrated.
Useful? React with 👍 / 👎.
| }); | ||
|
|
||
| // Listen for plugin panel removal and clean up bottom panel tabs. | ||
| listen('plugin-panel-removed', (event) => { |
There was a problem hiding this comment.
Use an emitted event for plugin-tab removal
The tab cleanup listener is wired to plugin-panel-removed, but there is no emitter for that event in the current backend paths (I checked crates/conch_tauri/src/plugins/tauri_host_api.rs, which only emits plugin-panel-registered and plugin-widgets-updated). Because this callback never runs, disabling/unloading a plugin leaves stale bottom-panel tabs in the UI for the rest of the session.
Useful? React with 👍 / 👎.
Summary
Adds a tabbed bottom panel with a built-in Notifications history tab that logs all toast notifications from the current session. Plugins that register bottom panels get their own tabs alongside it.
Changes
frontend/toast.jsgetHistory(),onNotification(),clearHistory()APIfrontend/notification-panel.jsfrontend/index.htmlfrontend/plugin-widgets.jssrc/lib.rsbottom_panel_visiblein SavedLayout/WindowLayoutTest plan
cargo test --workspace— 346 tests pass