Fix panel resize not updating visually on first drag#63
Merged
Conversation
The xterm.js WebGL canvas was overpainting the panel area during drag because #terminal-host lacked overflow:hidden. The canvas retained its old pixel dimensions while the flex layout shrank, covering the panel until the debounced fitAddon.fit() fired 100ms later. - Add overflow:hidden to #terminal-host so the canvas is clipped immediately when the flex layout recalculates - Switch resize handles from mouse events to pointer events with setPointerCapture to prevent native drag-and-drop interference - Block dragstart on resize handles and set touch-action:none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#terminal-hostlackedoverflow: hidden— the canvas retained its old pixel dimensions while the flex layout shrank, covering the panel until the debouncedfitAddon.fit()fired 100ms latersetPointerCapture()to prevent native drag-and-drop interferencedragstartprevention andtouch-action: noneon resize handlesTest plan
🤖 Generated with Claude Code