Add LTC3220 driver #3005
Add LTC3220 driver #3005
Conversation
edelweiseescala
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
edelweiseescala
force-pushed
the
main
branch
4 times, most recently
from
6a5debb to
d57b64f
Compare
drivers/leds/leds-ltc3220.c
Outdated
| } | ||
|
|
||
| static ssize_t ltc3220_shutdown_store(struct device *dev, | ||
| struct device_attribute *devAttr, |
There was a problem hiding this comment.
devAttr is in camel case can you fix to match Linux Kernel style
drivers/leds/leds-ltc3220.c
Outdated
| } | ||
|
|
||
| static ssize_t ltc3220_force_cpo_2x_store(struct device *dev, | ||
| struct device_attribute *devAttr, |
drivers/leds/leds-ltc3220.c
Outdated
| } | ||
|
|
||
| static ssize_t ltc3220_force_cpo_1p5x_store(struct device *dev, | ||
| struct device_attribute *devAttr, |
drivers/leds/leds-ltc3220.c
Outdated
| } | ||
|
|
||
| static ssize_t ltc3220_quick_write_store(struct device *dev, | ||
| struct device_attribute *devAttr, |
drivers/leds/leds-ltc3220.c
Outdated
| } | ||
|
|
||
| static int ltc3220_set_command(struct ltc3220_platform_data *platform_data, | ||
| bool is_shutdown, bool force2x, bool force1p5, bool quickWrite) |
There was a problem hiding this comment.
quickWrite is in camel case can you fix it according to Linux Kernel styling guide?
|
Could you format your commits so that there are spaces between labels? eg:
Additionally, could you add some more context regarding the commits? You can see more examples here: https://lore.kernel.org/linux-arm-kernel/ |
drivers/leds/leds-ltc3220.c
Outdated
| #define LTC3220_ULED18 0x12 | ||
| #define LTC3220_GRAD_BLINK 0x13 | ||
|
|
||
| static int ltc3220_write(struct i2c_client *client, u8 reg, u8 val) |
There was a problem hiding this comment.
Do we need another function call for this? I dont see any extra handling being done
There was a problem hiding this comment.
Agreed. I don't see any real benefit in these wrappers. I would also see if regmap is a possibility
drivers/leds/leds-ltc3220.c
Outdated
| { | ||
| int ret; | ||
| struct i2c_client *client = uled->client; | ||
| u8 reg_val = (mode << 6) | current_level; |
There was a problem hiding this comment.
This could overflow. Masking can prevent that. e.g. u8 reg_val = ((mode & 0x03) << 6) | (current_level & 0x3F);
There was a problem hiding this comment.
Yeah, as I said in another comment I would just consider FIELD_PREP()
|
|
||
| #define NUM_LEDS 18 | ||
|
|
||
| #define MAX_CURRENT 64 |
There was a problem hiding this comment.
Not sure about this one, but isn't it a 6-bit field? If so, it should be 0-63 so, #define MAX_CURRENT 63
drivers/leds/leds-ltc3220.c
Outdated
| struct ltc3220_uled_cfg *uled_cfg; | ||
|
|
||
| current_level = (int)brightness; | ||
| if (current_level > MAX_CURRENT) |
There was a problem hiding this comment.
You know the code way better than I do, but shouldn't that be an error? If it's fine to continue with current capped at max, at least a dev_info should be printed?
There was a problem hiding this comment.
Not sure either, some subsystems (like hwmon) don't consider these stuff as hard errors and just tell you to do clamp()
There was a problem hiding this comment.
I will be removing this, upon checking led subsystem already caps the value to the max if the user inputs a value exceeding the max. Thank you!
drivers/leds/leds-ltc3220.c
Outdated
| platform_data->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH); | ||
| if (IS_ERR(platform_data->reset_gpio)) { | ||
| dev_err(&client->dev, "Fail to set reset GPIO\n"); | ||
| return -ENOMEM; |
There was a problem hiding this comment.
since IS_ERR() has returned an error, you should pass it on instead of hardcoding ENOMEM, ie PTR_ERR(platform_data->reset_gpio);
There was a problem hiding this comment.
In fact, return dev_err_probe(dev, PTR_ERR(platform_data->reset_gpio), ...);
| #ifndef __LINUX_I2C_LTC3220_H | ||
| #define __LINUX_I2C_LTC3220_H | ||
|
|
||
| #define NUM_LEDS 18 |
There was a problem hiding this comment.
Can you add a LTC3220 prefix before these defines like you do in leds-ltc3220.c i.e LTC3220_NUM_LEDS ?
| compatible: | ||
| enum: | ||
| - lltc,ltc3220 | ||
| - lltc,ltc3220-1 |
| description: | | ||
| I2C slave address | ||
| 0x1c for ltc3220 | ||
| 0x1d for ltc3220-1 |
There was a problem hiding this comment.
Drop the description here. It is already obvious
| maintainers: | ||
| - Edelweise Escala <edelweise.escala@analog.com> | ||
|
|
||
| description: | |
| reset-gpios: | ||
| maxItems: 1 | ||
| description: | | ||
| GPIO attached to the chip's reset pin |
There was a problem hiding this comment.
Ditto about the description
| $ref: common.yaml# | ||
| properties: | ||
| reg: | ||
| description: | |
drivers/leds/leds-ltc3220.c
Outdated
| platform_data->led_cdev.groups = ltc3220_config_groups; | ||
| ret = devm_led_classdev_register_ext(&client->dev, | ||
| &platform_data->led_cdev, | ||
| &init_data_config); |
There was a problem hiding this comment.
What is the above about? Is it like device level settings instead of individual LED settings?
There was a problem hiding this comment.
It is like device level settings
drivers/leds/leds-ltc3220.c
Outdated
| return -ENOMEM; | ||
| } | ||
|
|
||
| ltc3220_reset(platform_data); |
There was a problem hiding this comment.
This is typically done in the beginning. In fact, this is bogus... Note that you're doing this after calling devm_led_classdev_register_ext() which will expose the userspace interfaces. So, effectively you can now race against userspace in a way that userspace does some configuration and then a reset happens.
drivers/leds/leds-ltc3220.c
Outdated
| MODULE_AUTHOR("Edelweise Escala <edelweise.escala@analog.com>"); | ||
| MODULE_DESCRIPTION("LED driver for LTC3220 controllers"); | ||
| MODULE_LICENSE("GPL"); | ||
| MODULE_ALIAS("platform:leds-ltc3220"); |
There was a problem hiding this comment.
Typically not used anymore
| @@ -0,0 +1,64 @@ | |||
| /* SPDX-License-Identifier: GPL-2.0-or-later */ | |||
| struct gpio_desc *reset_gpio; | ||
| }; | ||
|
|
||
| #endif /* __LINUX_I2C_LTC3220_H */ |
There was a problem hiding this comment.
Please drop the header file and move it to the source code. This is not supposed to be shared with any other source file AFAICT. Also, drop platform_data from the struct. Just name it struct ltc3220 or struct ltc3220_state. Platform data reference a very old way of doing things that is no longer used
Add dt-binding for ltc3220. LTC3220 18 Channel LED driver Signed-off-by: edelweiseescala <edelweise.escala@analog.com>
Add documentation for different Custom ABI added for LTC3220. Signed-off-by: edelweiseescala <edelweise.escala@analog.com>
Add driver for ltc3220. LTC3220 18 Channel LED Driver Signed-off-by: edelweiseescala <edelweise.escala@analog.com>
Add entry for LTC3220 driver Signed-off-by: edelweiseescala <edelweise.escala@analog.com>
6 participants
PR Description
PR Type
PR Checklist