feat(Examples): MSDK-1250: Add OWM Example for MAX32690 #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dung Nguyen <dung.nguyen@analog.com>
ttmut
requested changes
Nov 27, 2025
Contributor
ttmut
left a comment
ttmut
left a comment
There was a problem hiding this comment.
Thanks for the work! I’ve left some comments, mostly concerning styling.
| void setcrc8(uint8_t reset) | ||
| { | ||
| utilcrc8 = reset; | ||
| return; |
Comment on lines
+78
to
+79
| utilcrc8 = dscrc_table[utilcrc8 ^ x]; | ||
| return utilcrc8; |
Contributor
There was a problem hiding this comment.
Suggested change
| utilcrc8 = dscrc_table[utilcrc8 ^ x]; | |
| return utilcrc8; | |
| utilcrc8 = dscrc_table[utilcrc8 ^ x]; | |
| return utilcrc8; |
For readability.
Comment on lines
+101
to
+105
| if (MXC_OWM_Reset() == 1) { | ||
| //printf("OK: 1-wire devices reponded during the presence pulse\n"); | ||
| } else { | ||
| return -2; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (MXC_OWM_Reset() == 1) { | |
| //printf("OK: 1-wire devices reponded during the presence pulse\n"); | |
| } else { | |
| return -2; | |
| } | |
| if (MXC_OWM_Reset() == 1) { | |
| printf("OK: 1-wire devices reponded during the presence pulse\n"); | |
| } else { | |
| printf("FAIL: Relevant error message here\n"); | |
| return -2; | |
| } |
Could do this or just
Suggested change
| if (MXC_OWM_Reset() == 1) { | |
| //printf("OK: 1-wire devices reponded during the presence pulse\n"); | |
| } else { | |
| return -2; | |
| } | |
| if (MXC_OWM_Reset() != 1) { | |
| printf("FAIL: Relevant error message here\n"); | |
| return -2; | |
| } |
Comment on lines
+114
to
+118
| if (MXC_OWM_Reset() == 1) { | ||
| //printf("OK: 1-wire devices reponded during the presence pulse after Overdrive\n"); | ||
| } else { | ||
| return -4; | ||
| } |
| /* Read the ROM ID */ | ||
| memset(buffer, 0, sizeof(buffer)); | ||
| if (MXC_OWM_Read(buffer, 8) < 0) { | ||
| return -5; |
Contributor
There was a problem hiding this comment.
Might be a good idea to add an error log here as well.
Comment on lines
+33
to
+40
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
We only need a single newline.
| "__GNUC__" | ||
| ], | ||
| "intelliSenseMode": "gcc-arm", | ||
| "compilerPath": "${config:cfs.toolchain.armAArch32GCC.path}/bin/arm-none-eabi-gcc.exe", |
Contributor
There was a problem hiding this comment.
I do not think this file is supposed to hold CFS references. You can copy from an existing example and adjust accordingly.
| { | ||
| "configurations": [ | ||
| { | ||
| "name": "CFS: Debug with GDB and OpenOCD (ARM Embedded)", |
Contributor
There was a problem hiding this comment.
Again, this file seems to be tailored towards CFS integration. I suggest using launch.json from an existing example as a reference.
| "C_Cpp.default.forcedInclude": [ | ||
| "${workspaceFolder}/build/project_defines.h" | ||
| ], | ||
| "cfs.project.target": "MAX32690", |
| # | ||
| # Copyright (C) 2022-2023 Maxim Integrated Products, Inc. (now owned by | ||
| # Analog Devices, Inc.), | ||
| # Copyright (C) 2023-2024 Analog Devices, Inc. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2023-2024 Analog Devices, Inc. | |
| # Copyright (C) 2023-2025 Analog Devices, Inc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add OWM example for MAX32690 to read ROM-ID of 1-Wire slave device
Connect 1-Wire pin, VCC and GND to the target.
Checklist Before Requesting Review