Added support for marking Martial Arts as Supernal.#1
Open
AlexGodofsky wants to merge 3 commits intoanathema:masterfrom
Open
Added support for marking Martial Arts as Supernal.#1AlexGodofsky wants to merge 3 commits intoanathema:masterfrom
AlexGodofsky wants to merge 3 commits intoanathema:masterfrom
Conversation
Caste/Favored and Supernal limits correctly, and enforces consistency with the tagged state of Brawl.
Martial Arts excellency now correctly granted upon tagging MA and having a dot in it, OR learning MA and learning at least one MA charm.
Member
|
Hey, @AlexGodofsky, thanks for the pull request. I left some questions with the individual commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles the Caste/Favored and Supernal limits correctly, and enforces consistency with the tagged state of Brawl. Also handles the ability dot / bonus point limits correctly.
I tried to be as minimal as possible with respect to changing the APIs. There's one slightly icky kludge in making
TraitStateImpl.changeStateToprotected, but I figured that was better than largely copy/pasting theTraitStateImplimplementation code (and using inner classes appears to be disfavored in your design patterns).