Prevent fractions of thumbnails. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fractional thumbnail on the right end of the bar was really bugging me, so I set out to try and prevent fractional thumbnails by calculating the closest width necessary to perfectly fit the thumbnails into the bar. Some thumbnails will end up with a picWidth +1 larger than others to make up for fractions. This works regardless of what picWidth you set.
Old bar with fractional thumbnail on the end (screen taken from readme.md)
New bar with no fractional thumbnails
(note the difference in bar lengths is just due to how the screenshots were taken. It's not from any changes in the code)