-
Notifications
You must be signed in to change notification settings - Fork 131
Add individual README.md to each sample #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces dedicated Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds individual README.md files to each sample application, which is a great addition for improving the usability and understanding of each sample. The new documentation is clear and provides helpful code snippets. My review focuses on improving the maintainability of the documentation by suggesting the use of relative links, and I've also provided feedback on the code snippets to align them with Android architecture best practices and improve code robustness. Several suggestions address potential null pointer exceptions, race conditions, and violations of architectural principles.
baa493c to
7703865
Compare
7703865 to
ed22c96
Compare
| } | ||
|
|
||
| ``` | ||
| * **Strongly recommended:** When a view model or the business logic is modified in the code of a sample, verify that these changes are properly reflected in the README.md of this sample. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoping this works. Maybe we should also add "if model version is updated in the sample make sure it's updated in the readme as well", wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about adding a separate section for the Readme? Adding it to the view model section implies that the business logic will live in that file. Instead we could say something like:
## README
* **Strongly recommended:** Code changes to business logic should be reflected in this sample's README file.
* **Recommended:** When changes are made to the UI, the screenshot in this sample's README file should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are good suggestion in principle, but we should test them to see if they work.
In my (limited) testing, I wasn't able to have Gemini Code Assist specifically picking up an isolated model change and suggesting a ReadMe update.
So I will default to removing the model version from the ReadMe files for now.
| ``` | ||
|
|
||
| Read more about [getting started with Gemini](https://developer.android.com/ai/gemini/get-started) in the Android Documentation. | ||
| Read more about the [Gemini API](https://developer.android.com/ai/gemini) in the Android Documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "Gemini API" can refer to a lot of things. Would you consider adding a reference to "cloud" here somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Gemini API" is the name of the product to enable access to Flash and Pro to developers. So I think we should keep it.
Add individual README.md to each sample