Reject Android attestations chaining to the software root #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_803547414
branch
5 times, most recently
from
6ce1f20 to
17acc10
Compare
Some older Android devices do not support Android Key Attestation with a hardware-backed key and fall back to using a software-based solution. These attestations chain up to a root certificate with CN = Android Keystore Software Attestation Root. These attestations are not considered trustworthy for use cases requiring hardware-backed keys. To prevent accidental misconfiguration, this change also adds a check to ensure the software root is never configured as the main trust anchor. PiperOrigin-RevId: 834371493
copybara-service
bot
force-pushed
the
test_803547414
branch
from
17acc10 to
ab49edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject Android attestations chaining to the software root
Some older Android devices do not support Android Key Attestation with a hardware-backed key and fall back to using a software-based solution. These attestations chain up to a root certificate with CN = Android Keystore Software Attestation Root. These attestations are not considered trustworthy for use cases requiring hardware-backed keys.
To prevent accidental misconfiguration, this change also adds a check to ensure the software root is never configured as the main trust anchor.