SSS-3 ticket PR #10
Open
SSS-3 ticket PR #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag-amx
requested changes
Jul 13, 2023
anurag-amx
left a comment
anurag-amx
left a comment
There was a problem hiding this comment.
- provide description .
- Unable to understand the PR. Is sss3Test.js added only? why so many commented lines?
Author
In sss3Test.js testing is done to check exception handling, there are no code changes done in this PR. Exception Handling issue was already resolved in the previous PR and merged also. |
anurag-amx
previously approved these changes
Jul 20, 2023
AmodChaubey1110
dismissed
anurag-amx’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created for testing purposes only, No code changes are done. Testing is done to check Exception Handling in placeOrder, modifyOrder, and getOrderBook APIs for the error " Cannot read property 'status' of undefined ".