Skip to content

Conversation

@Amol-Bhagwat-187
Copy link

Market data api added. New function marketData added in smartapi-connect.js

Copy link

@anurag-amx anurag-amx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What is Junit Dev Test cases?
  2. Can you change [example/test.js] to something meaningful e.g. [example/testsuite.js]

@Amol-Bhagwat-187
Copy link
Author

  1. The purpose of unit testing is to check the behaviour of a particular unit of code to ensure that it performs as expected and produces the correct output for given inputs. Unit tests help identify bugs or errors in the code early in the development process.

  2. test.js file renamed as testsuite.js

anurag-amx
anurag-amx previously approved these changes Aug 9, 2023
@anurag-amx anurag-amx dismissed their stale review September 26, 2023 02:55

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants