Fix ReflectionMethod::__construct() deprecations #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues: 1) /symfony/vendor/angelov/phpunit-php-vcr/src/Subscribers/AttributeResolverTrait.php:28 Calling ReflectionMethod::__construct() with 1 argument is deprecated, use ReflectionMethod::createFromMethodName() instead 2) /symfony/vendor/angelov/phpunit-php-vcr/src/Subscribers/AttributeResolverTrait.php:51 Calling ReflectionMethod::__construct() with 1 argument is deprecated, use ReflectionMethod::createFromMethodName() instead
|
ReflectionMethod::createFromMethodName seems to be introduced in php 8.3, so merging this PR may require bumping the php dependencies to 8.3. |
|
Thank you for the contribution @nicodemuz! I think we can avoid the version bumping by checking the PHP version during execution ( |
|
@angelov updated my branch |
|
@angelov fixed the checks |
|
Thank you @nicodemuz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
/symfony/vendor/angelov/phpunit-php-vcr/src/Subscribers/AttributeResolverTrait.php:28 Calling ReflectionMethod::__construct() with 1 argument is deprecated, use ReflectionMethod::createFromMethodName() instead
/symfony/vendor/angelov/phpunit-php-vcr/src/Subscribers/AttributeResolverTrait.php:51 Calling ReflectionMethod::__construct() with 1 argument is deprecated, use ReflectionMethod::createFromMethodName() instead
Deprecations reported when executing phpunit in php 8.4.