Skip to content

Add support for beforeSend callback #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for beforeSend callback #68

wants to merge 3 commits into from

Conversation

@zokioki
Copy link

@zokioki zokioki commented Dec 25, 2021 •
edited
Loading

This allows ahoy to be configured with an optional beforeSend callback, allowing the user to modify a request before sending if needed. For example:

ahoy.configure({
  beforeSend: (xhr, settings) => {
    // do something with request ...
  }
});

One use case for this is to allow for the setting of custom headers on a per-request basis.

@zokioki
allow a beforeSend callback to be set in config
ba5d375 
This change allows the user to specify a callback which will fire
before a request is triggered. The function will have access to
the XHR object and settings object.
@zokioki
make callback data object consistent between ajax and xhr requests
874465a 
This ensures the request data being passed to the beforeSend callback
is in the same format for both the ajax and XMLHttpRequest versions.
@zokioki
update readme to reflect new config option
3294385
@zokioki zokioki marked this pull request as ready for review December 25, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zokioki