Fix premature closure of cloze when inside MathJax#4612
Open
athith-g wants to merge 1 commit intoankitects:mainfrom
Open
Fix premature closure of cloze when inside MathJax#4612athith-g wants to merge 1 commit intoankitects:mainfrom
athith-g wants to merge 1 commit intoankitects:mainfrom
Conversation
* FIX premature cloze termination inside MathJax * ADD regression test for MathJax cloze parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloze tokenizer in
rslib/src/cloze.rspreviously treated any occurrence of}}as a cloze terminator, even when it appeared inside MathJax expressions.Example:
{{c1:: ( \frac{1}{ \sqrt{ \pi }} ) }}
The
}}from\sqrt{\pi}}would cause the cloze to terminate early, resulting in incorrect parsing and rendering.normal_text()now tracks when the scanner is inside a MathJax region (\(...\)or\[...\]). While inside MathJax,}}is ignored as a cloze terminator.Cloze openings are still recognized inside MathJax.