Open
Conversation
V0.7.0 introduces the Digest types and converts Vecs into fixed sized arrays
This allows us to decode directly into a Binary saving us if we wish to convert it to some other type than always going through Vec<u8> which will encur another copy
mariari
force-pushed
the
mariari/better-error-handling
branch
from
62ca643 to
8bfcd43
Compare
This is helpful as often we need to serialize bincode data, and having a uniform way to handle the error type lets us not worry about doing these conversions by hand.
Unwraps that don't change signatures are now converted to being safer. However this is not everything and further work is required. Namely tests are not converted, this would normally be fine, but tests are exported to Elixir and thus have a chance to crash the VM. Further functions like: tests::create_an_action Have non Result outputs, meaning greater refactoring is required to handle these.
mariari
force-pushed
the
mariari/better-error-handling
branch
3 times, most recently
from
03930e8 to
e900d68
Compare
Doing this improperly can crash the Erlang VM. Every instnace of this where the end type is a result type or something analygous (like the Term<'a> type) now is expectless. More work needs to be done for functions that do not fit this architype which is 13 methods in arm/src
mariari
force-pushed
the
mariari/better-error-handling
branch
from
e900d68 to
b4d5b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to help out with the better error handling efforts.
Please read the message on the commit messages. Each commit is minimal to be understood, and can be torn apart. I.E. if there are changes that are not wanted, it should be easy to cut out a particular change and deal with minor issues when rearranging the commits.
The PR is not ready, but the commits can be reviewed as is