Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While persuing the goal of using the bellpepper and bellman cryptographic libraries together, the Rust borrow checker started presenting errors. This was due to the fact the
rootandnamespacemethods of aConstraintSystemreturn mutable references, and this was constraining how the bellpepper library could be used. This PR modifiesrootandnamespaceto take a callback (accepting a mutable reference) instead of just returning the mutable reference. Doing this allows more flexibility in bellpepper usage without actually changing any actual logic in the library. It should hopefully be provable that the new code is equivalent to the old code.