feat(desktop): support all local path uploads from prompt input#18139
Open
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Open
feat(desktop): support all local path uploads from prompt input#18139anduimagui wants to merge 3 commits intoanomalyco:devfrom
anduimagui wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #18143
Type of change
What does this PR do?
This teaches the desktop prompt flow to treat dropped or pasted local paths as real uploads when the path points at supported media, while keeping non-media files as
@pathmentions. It also dedupes the native desktop drop event against the browser drop event so the same file does not get inserted twice.This is part of the broader Desktop file-drop gap tracked in #18143, where Desktop currently rejects or limits more file types than TUI when inserting dropped files into prompt input.
How did you verify your code works?
bun typecheckinpackages/app, but the workspace currently fails before these changes due to missing local type/runtime deps in this environment (solid-js,@opencode-ai/ui,effect,ghostty-web, and related packages).bun test:e2e -- e2e/prompt/prompt-drop-native-event.spec.ts, but this environment is missing@playwright/test.packages/app/e2e/prompt/prompt-drop-native-event.spec.tsfor native drop image preview and duplicate native/browser drop handling.Screenshots / recordings
Not included.
Checklist