fix(plan): resolve model from agent config in plan tools#18163
Open
filipeandre wants to merge 1 commit intoanomalyco:devfrom
Open
fix(plan): resolve model from agent config in plan tools#18163filipeandre wants to merge 1 commit intoanomalyco:devfrom
filipeandre wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
a443499 to
fb47bf8
Compare
fb47bf8 to
fd782a8
Compare
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #9296
Type of change
What does this PR do?
When a user configures a specific model for the
buildorplanagent (e.g.agent.build.model = "openai/gpt-4o"), the plan tools were ignoring it. BothPlanExitToolandPlanEnterToolwere always falling back to the last model seen in the session history viagetLastModel, so the build agent would inherit the plan agent's model instead of its own configured one.This PR adds a
resolveModelhelper that callsAgent.get(agentName)first and uses the configured model if present, only falling back to the last session model when none is set.PlanExitToolresolves for thebuildagent andPlanEnterToolfor theplanagent.How did you verify your code works?
Added two tests in
packages/opencode/test/tool/plan.test.ts:agent.build.modelis configured, the message written byPlanExitTooluses that model.Screenshots / recordings
N/A — not a UI change.
Checklist