Skip to content

Conversation

@B-Whitt
Copy link
Contributor

@B-Whitt B-Whitt commented Dec 5, 2025

  • Add FORMS_URLFIELD_ASSUME_HTTPS setting
  • Update channels to 4.1.x
  • Django 5.0.14 installed via dependency resolution
  • Django 5.2 LTS (support until April 2028)
  • drf-spectacular 0.29.x
  • channels 4.3.x
  • django-rq 3.2.x (requires rq 2.x)
  • rq 2.6.x
  • rq-scheduler 0.14.x (compatible with rq 2.x)
  • django-filter 25.2
  • Update documentation URLs to Django 5.2

Note: DRF remains at 3.15.x due to django-ansible-base constraint (requires DRF <3.16 for OAuth2Application compatibility)

Assisted-By: Claude Code

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.20%. Comparing base (f25ba27) to head (582544b).

@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   94.81%   91.20%   -3.61%     
==========================================
  Files         338      232     -106     
  Lines       20053     9939   -10114     
==========================================
- Hits        19013     9065    -9948     
+ Misses       1040      874     -166     
Flag Coverage Δ
unit-int-tests-3.11 91.20% <100.00%> (-3.56%) ⬇️
unit-int-tests-3.12 91.20% <100.00%> (-3.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/asgi.py 100.00% <ø> (ø)
src/aap_eda/core/models/user.py 100.00% <ø> (ø)
src/aap_eda/settings/core.py 100.00% <100.00%> (ø)
src/aap_eda/settings/defaults.py 100.00% <ø> (ø)
src/aap_eda/settings/post_load.py 94.55% <ø> (ø)
src/aap_eda/urls.py 100.00% <ø> (ø)
src/aap_eda/wsgi.py 100.00% <ø> (ø)

... and 106 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@B-Whitt B-Whitt added run-e2e and removed run-e2e labels Dec 8, 2025
@B-Whitt B-Whitt marked this pull request as ready for review December 8, 2025 14:30
@B-Whitt B-Whitt requested a review from a team as a code owner December 8, 2025 14:30
@B-Whitt B-Whitt added the run-e2e label Dec 8, 2025
@B-Whitt B-Whitt force-pushed the django-50-upgrade branch 3 times, most recently from 607216f to 06750d6 Compare December 10, 2025 20:45
@ttuffin
Copy link
Contributor

ttuffin commented Dec 11, 2025

@B-Whitt can you look into the failing e2e tests?

- Add FORMS_URLFIELD_ASSUME_HTTPS setting
- Update channels to 4.1.x
- Django 5.0.14 installed via dependency resolution
- Django 5.2 LTS (support until April 2028)
- drf-spectacular 0.29.x
- channels 4.3.x
- django-rq 3.2.x (requires rq 2.x)
- rq 2.6.x
- rq-scheduler 0.14.x (compatible with rq 2.x)
- django-filter 25.2
- Update documentation URLs to Django 5.2

Note: DRF remains at 3.15.x due to django-ansible-base
constraint (requires DRF <3.16 for OAuth2Application compatibility)

Assisted-By: Claude Code
@sonarqubecloud
Copy link

@B-Whitt
Copy link
Contributor Author

B-Whitt commented Dec 17, 2025

@B-Whitt can you look into the failing e2e tests?

@ttuffin e2e failures fixed in this PR - https://github.com/ansible/eda-qa/pull/499. Resolve test failures caused by Django 5.x's stricter email TLD validation that no longer allows digits in top-level domains. eda-server e2e tests are passing with the eda-qa updates. See tests here

@B-Whitt B-Whitt merged commit ad278f8 into ansible:main Dec 18, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants